sirius/onionwire
1
0
Fork 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions 3

fix(cli): hide store passphrase like a password prompt #14

Merged
sirius merged 2 commits from feat/hidden-store-passphrase into main 2026-09-11 01:18:47 +00:00
Conversation 0 Commits 2 Files changed 7 +113 -25
sirius commented 2026-09-11 01:09:04 +00:00
Owner
Copy link

Summary

  • onionwire: store passphrase: no longer uses stdin.read_line (echoed).
  • TTY prompt via rpassword (echo off). Empty still fails closed.
  • ONIONWIRE_STORE_PASSPHRASE still skips the prompt (visible in /proc/<pid>/environ).

Tests

cargo test --locked green (new store tests for env vs prompt). cargo clippy --locked --all-targets -- -D warnings clean.

## Summary - `onionwire: store passphrase:` no longer uses `stdin.read_line` (echoed). - TTY prompt via `rpassword` (echo off). Empty still fails closed. - `ONIONWIRE_STORE_PASSPHRASE` still skips the prompt (visible in `/proc/<pid>/environ`). ## Tests `cargo test --locked` green (new store tests for env vs prompt). `cargo clippy --locked --all-targets -- -D warnings` clean.
sirius added 1 commit 2026-09-11 01:09:05 +00:00
fix(cli): hide store passphrase like a password prompt
All checks were successful
ci / test (pull_request) Successful in 4m54s
Details
c5019f1737 
stdin read_line echoed the passphrase. rpassword disables tty echo.
ONIONWIRE_STORE_PASSPHRASE still skips the prompt.
sirius added 1 commit 2026-09-11 01:18:34 +00:00
Merge branch 'main' into feat/hidden-store-passphrase
All checks were successful
ci / test (pull_request) Successful in 3m44s
Details
b354632552
sirius merged commit 389d8f16c4 into main 2026-09-11 01:18:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sirius/onionwire#14
No description provided.
Delete branch "feat/hidden-store-passphrase"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?