sirius/onionwire
1
0
Fork 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions 3

feat(wallet): require RPC digest login and cap reads #9

Closed
sirius wants to merge 0 commits from wt/t_885cbe11 into main
pull from: wt/t_885cbe11
merge into: sirius:main
Conversation 1 Commits - Files changed - +352 -47
sirius commented 2026-09-11 00:15:41 +00:00
Owner
Copy link

Summary

  • F5: ONIONWIRE_WALLET_RPC requires userinfo or ONIONWIRE_WALLET_RPC_LOGIN.
  • Speaks HTTP Digest (RFC 2617) matching monero-wallet-rpc --rpc-login; open RPC (HTTP 200 without a challenge) is refused.
  • Caps RPC reads at 1 MiB; 5s timeout stays fail-closed.
  • Rejects .onion RPC URLs (no Arti dial). Loopback only.
  • README: operator must use --rpc-login. Password is not logged.

Tests

cargo test --locked 106 passed / 3 ignored. cargo clippy --locked -- -D warnings clean.

## Summary - F5: `ONIONWIRE_WALLET_RPC` requires userinfo or `ONIONWIRE_WALLET_RPC_LOGIN`. - Speaks HTTP Digest (RFC 2617) matching `monero-wallet-rpc --rpc-login`; open RPC (HTTP 200 without a challenge) is refused. - Caps RPC reads at 1 MiB; 5s timeout stays fail-closed. - Rejects `.onion` RPC URLs (no Arti dial). Loopback only. - README: operator must use `--rpc-login`. Password is not logged. ## Tests `cargo test --locked` 106 passed / 3 ignored. `cargo clippy --locked -- -D warnings` clean.
sirius added 1 commit 2026-09-11 00:15:41 +00:00
[verified] feat(wallet): require RPC digest login and cap reads
All checks were successful
ci / test (pull_request) Successful in 3m8s
Details
125aafb816 
Refuse unauthenticated ONIONWIRE_WALLET_RPC, speak HTTP Digest like
monero-wallet-rpc --rpc-login, cap responses at 1 MiB, and reject
.onion RPC URLs instead of half-dialing them over TCP.
sirius commented 2026-09-11 00:36:02 +00:00
Author
Owner
Copy link

Superseded by the bundle PR: #12

Superseded by the bundle PR: https://forgejo.siriusdevops.com/sirius/onionwire/pulls/12
sirius closed this pull request 2026-09-11 00:36:02 +00:00
All checks were successful
ci / test (pull_request) Successful in 3m8s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sirius/onionwire#9
No description provided.
Delete branch "wt/t_885cbe11"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?